Skip to content

d_a_obj_brakeeff debug equivalent#2906

Merged
TakaRikka merged 2 commits intozeldaret:mainfrom
ItsNiklas:d_a_obj_debugs
Dec 2, 2025
Merged

d_a_obj_brakeeff debug equivalent#2906
TakaRikka merged 2 commits intozeldaret:mainfrom
ItsNiklas:d_a_obj_debugs

Conversation

@ItsNiklas
Copy link
Contributor

  • d_a_obj_brakeeff debug equivalent
  • .rodata lbl, RTTI issues remain
  • clang-format in a separate commit

@decomp-dev
Copy link

decomp-dev bot commented Dec 2, 2025

Report for ShieldD (ffc86e0 - 3a532b3)

📈 Matched code: 32.10% (+0.01%, +1984 bytes)

✅ 7 new matches
Unit Function Bytes Before After
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff useHeapInit(fopAc_ac_c*) +149 68.21% 100.00%
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff daObj_Brakeeff_Create(fopAc_ac_c*) +92 76.48% 100.00%
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff obj_brakeeff_1(obj_brakeeff_class*) +64 88.10% 100.00%
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff daObj_Brakeeff_Delete(obj_brakeeff_class*) +33 68.62% 100.00%
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff action(obj_brakeeff_class*) +29 68.65% 100.00%
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff daObj_Brakeeff_Execute(obj_brakeeff_class*) +25 90.50% 100.00%
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff daObj_Brakeeff_Draw(obj_brakeeff_class*) +17 88.49% 100.00%

Report for RZDE01_00 (ffc86e0 - 3a532b3)

📈 1 improvement in unmatched functions
Unit Function Bytes Before After
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff useHeapInit(fopAc_ac_c*) 0 99.86% 99.91%
📉 1 regression in unmatched functions
Unit Function Bytes Before After
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff daObj_Brakeeff_Execute(obj_brakeeff_class*) -6 23.47% 22.67%

Report for GZ2J01 (ffc86e0 - 3a532b3)

No changes

Report for GZ2P01 (ffc86e0 - 3a532b3)

No changes

Report for Shield (ffc86e0 - 3a532b3)

📈 1 improvement in unmatched functions
Unit Function Bytes Before After
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff useHeapInit(fopAc_ac_c*) 0 85.46% 85.48%
📉 2 regressions in unmatched functions
Unit Function Bytes Before After
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff obj_brakeeff_1(obj_brakeeff_class*) -51 92.12% 82.99%
d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff daObj_Brakeeff_Execute(obj_brakeeff_class*) -8 84.96% 81.47%

Report for GZ2E01 (ffc86e0 - 3a532b3)

No changes

@ItsNiklas
Copy link
Contributor Author

ItsNiklas commented Dec 2, 2025

RZDE01_00 regression is a side-effect inline. Shield does not inline cXyz::set, unlike GCN.

@ItsNiklas
Copy link
Contributor Author

Just realized this was already worked on in #2761, but not really finished. My bad!

@TakaRikka TakaRikka merged commit 9a69fa3 into zeldaret:main Dec 2, 2025
6 checks passed
@ItsNiklas ItsNiklas deleted the d_a_obj_debugs branch December 3, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants